Allow applications to test if a user could edit a certain field by clicking "Edit Thing"
ClosedPublic
Actions

Authored by epriestley on Mar 8 2016, 12:47 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP8a7c96390862: Allow applications to test if a user could edit a certain field by clicking…

Summary

See D15432. There, we can use this test to check if the user could reassign the task by using "Edit Form" or the stacked actions, so any dedicated "claim" element is consistent with the other permissions.

Test Plan

Added a var_dump($can_reassign) after the call.
Saw true.
Edited the edit form, locked and disabled "Assigned To".
Saw false.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37198.Mar 8 2016, 12:47 PM

epriestley retitled this revision from to Allow applications to test if a user could edit a certain field by clicking "Edit Thing".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley mentioned this in D15432: Add spiffyier Assigned To panel in Maniphest.Mar 8 2016, 12:52 PM

chad accepted this revision.Mar 8 2016, 3:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2016, 3:16 PM

Closed by commit rP8a7c96390862: Allow applications to test if a user could edit a certain field by clicking… (authored by epriestley, committed by epriestley). · Explain WhyMar 8 2016, 6:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

22 lines

transactions/

editengine/

PhabricatorEditEngine.php

56 lines

Diff 37209

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php