Clean up Herald CSS
ClosedPublic
Actions

Authored by chad on Mar 6 2016, 9:05 PM.

Tags

None

Referenced Files

	F14011391: D15419.id.diff
	Thu, Oct 31, 11:42 PM

	F13999163: D15419.diff
	Thu, Oct 24, 1:08 PM

	F13996286: D15419.id37172.diff
	Wed, Oct 23, 7:46 PM

	F13962932: D15419.id37170.diff
	Oct 15 2024, 1:02 PM

	Unknown Object (File)
	Sep 19 2024, 9:15 AM

	Unknown Object (File)
	Sep 19 2024, 9:08 AM

	Unknown Object (File)
	Sep 18 2024, 1:31 AM

	Unknown Object (File)
	Sep 14 2024, 9:32 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP8175f524e685: Clean up Herald CSS

Summary

I didn't test these very well and they looked silly when multiple rules applied.

Test Plan

Test various cases more, with single and multiple triggers.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37170.Mar 6 2016, 9:05 PM

chad retitled this revision from to Clean up Herald CSS.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 6 2016, 9:05 PM

epriestley accepted this revision.Mar 6 2016, 9:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2016, 9:33 PM

Closed by commit rP8175f524e685: Clean up Herald CSS (authored by chad, committed by chad). · Explain WhyMar 6 2016, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

herald/

herald.css

4 lines

Diff 37172

View Options

resources/celerity/map.php