Fix header tag on Hovercards
ClosedPublic
Actions

Authored by chad on Mar 5 2016, 6:27 AM.

Tags

None

Referenced Files

	F14054243: D15403.diff
	Fri, Nov 15, 11:16 PM

	F14050788: D15403.diff
	Thu, Nov 14, 8:42 PM

	F14036369: D15403.diff
	Sun, Nov 10, 9:57 AM

	F14031624: D15403.id37138.diff
	Sat, Nov 9, 11:34 AM

	F14031623: D15403.id37137.diff
	Sat, Nov 9, 11:34 AM

	F14031622: D15403.id37136.diff
	Sat, Nov 9, 11:34 AM

	F14031621: D15403.id.diff
	Sat, Nov 9, 11:34 AM

	F14023179: D15403.id37136.diff
	Wed, Nov 6, 11:47 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP5a43e2040eeb: Fix header tag on Hovercards

Summary

Switch to new method.

Test Plan

Hover over task, see tag in correct place.

Diff Detail

Repository

rP Phabricator

Branch

hovercard-two (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10998
Build 13589: Run Core Tests
Build 13588: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37136.Mar 5 2016, 6:27 AM

chad retitled this revision from to Fix header tag on Hovercards.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 5 2016, 6:27 AM

add icons to Paste, Passphrase
Fix icon spacing on Projects, Peopley

epriestley accepted this revision.Mar 5 2016, 11:57 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 11:57 AM

Closed by commit rP5a43e2040eeb: Fix header tag on Hovercards (authored by chad, committed by chad). · Explain WhyMar 5 2016, 3:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIHovercardView.php

2 lines

Diff 37136

View Options

src/view/phui/PHUIHovercardView.php

Fix header tag on HovercardsClosedPublicActions