Differential D15401

Unprototype Drydock
ClosedPublic
Actions

Authored by epriestley on Mar 5 2016, 1:19 AM.

Details

Reviewers

chad

Maniphest Tasks

T10246: Deploy Drydock in the Phacility cluster

Commits

Restricted Diffusion Commit
rP2f14a59b1d81: Unprototype Drydock

Summary

Ref T10246. Drydock still has a few outstanding issues, but it's mostly minor UI stuff and the documentation has reasonable caveats about it.

Broadly, I don't expect to make any major changes to Drydock in the future (i.e., all the fundamentals seem sound at this point) and it doesn't have any major technical debt or, like, obsolete APIs or anything.

Test Plan

Saw "Drydock" as not-a-prototype in Applications.

Diff Detail

Repository

rP Phabricator

Branch

dry27

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10987
Build 13576: Run Core Tests
Build 13575: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37128.Mar 5 2016, 1:19 AM

epriestley retitled this revision from to Unprototype Drydock.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10246: Deploy Drydock in the Phacility cluster.

chad accepted this revision.Mar 5 2016, 1:19 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 1:19 AM

Closed by commit rP2f14a59b1d81: Unprototype Drydock (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2016, 1:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

application/

PhabricatorDrydockApplication.php

4 lines

Diff 37128

View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Unprototype DrydockClosedPublicActions