Page MenuHomePhabricator
Differential D15386

Touch up HeraldView a bit more
ClosedPublic
Actions

Authored by chad on Mar 2 2016, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 5, 1:07 PM
Unknown Object (File)
Sun, Sep 1, 4:13 PM
Unknown Object (File)
Sun, Sep 1, 4:13 PM
Unknown Object (File)
Sun, Sep 1, 4:13 PM
Unknown Object (File)
Aug 27 2024, 2:58 AM
Unknown Object (File)
Aug 17 2024, 10:54 PM
Unknown Object (File)
Aug 16 2024, 5:02 PM
Unknown Object (File)
Aug 12 2024, 1:01 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe08d70a9a5c8: Touch up HeraldView a bit more
Summary

Better colors, move description to own box, cleaner spacing.

Test Plan

View a few herald rules

Diff Detail

Repository
rP Phabricator
Branch
herald-three (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10956
Build 13527: Run Core Tests
Build 13526: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37099.Mar 2 2016, 9:09 PM
chad retitled this revision from to Touch up HeraldView a bit more.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2016, 9:09 PM
epriestley accepted this revision.Mar 3 2016, 12:10 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 12:10 AM
Closed by commit rPe08d70a9a5c8: Touch up HeraldView a bit more (authored by chad, committed by chad). · Explain WhyMar 3 2016, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
herald/
controller/
22 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
application/
herald/
10 lines

Diff 37099

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/application/herald/herald.css

Loading...
Phabricator · Built by Phacility