Page MenuHomePhabricator
Differential D15386

Touch up HeraldView a bit more
ClosedPublic
Actions

Authored by chad on Mar 2 2016, 9:09 PM.
Tags
None
Referenced Files
F15524031: D15386.id37100.diff
Mon, Apr 21, 5:33 AM
F15522726: D15386.id37099.diff
Sun, Apr 20, 8:59 PM
F15521496: D15386.id.diff
Sun, Apr 20, 2:48 PM
F15519034: D15386.diff
Sat, Apr 19, 7:20 PM
F15491634: D15386.id37100.diff
Sat, Apr 12, 5:43 AM
F15485462: D15386.diff
Wed, Apr 9, 11:53 PM
F15456908: D15386.id.diff
Sun, Mar 30, 12:58 PM
F15448747: D15386.id.diff
Fri, Mar 28, 6:44 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe08d70a9a5c8: Touch up HeraldView a bit more
Summary

Better colors, move description to own box, cleaner spacing.

Test Plan

View a few herald rules

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37099.Mar 2 2016, 9:09 PM
chad retitled this revision from to Touch up HeraldView a bit more.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2016, 9:09 PM
epriestley accepted this revision.Mar 3 2016, 12:10 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 12:10 AM
Closed by commit rPe08d70a9a5c8: Touch up HeraldView a bit more (authored by chad, committed by chad). · Explain WhyMar 3 2016, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
herald/
controller/
22 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
application/
herald/
10 lines

Diff 37100

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/application/herald/herald.css

Loading...
Phabricator · Built by Phacility