Page MenuHomePhabricator
Differential D15376

Give HarbormasterBuildLogChunk a real table
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 8:12 PM.
Tags
None
Referenced Files
F15336300: D15376.id37080.diff
Sat, Mar 8, 6:40 PM
F15336299: D15376.diff
Sat, Mar 8, 6:40 PM
Unknown Object (File)
Tue, Feb 25, 2:26 AM
Unknown Object (File)
Fri, Feb 14, 4:17 AM
Unknown Object (File)
Feb 9 2025, 12:54 AM
Unknown Object (File)
Feb 9 2025, 12:54 AM
Unknown Object (File)
Feb 9 2025, 12:54 AM
Unknown Object (File)
Feb 4 2025, 9:57 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rPe174cac1b476: Give HarbormasterBuildLogChunk a real table
Summary

Ref T10457. Currently, this table is an ad-hoc table, but can easily be turned into a normal table.

This will make iterating over log chunks to compress and archive them easier.

Test Plan

Viewed logs, ran bin/storage adjust with no issues.

Diff Detail

Repository
rP Phabricator
Branch
dry16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10928
Build 13485: Run Core Tests
Build 13484: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37071.Mar 1 2016, 8:12 PM
epriestley retitled this revision from to Give HarbormasterBuildLogChunk a real table.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
chad accepted this revision.Mar 1 2016, 8:16 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 8:16 PM
chad updated this object.Mar 1 2016, 8:16 PM
chad edited edge metadata.
Closed by commit rPe174cac1b476: Give HarbormasterBuildLogChunk a real table (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 11:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
harbormaster/
storage/
25 lines
build/
6 lines
32 lines

Diff 37071

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterSchemaSpec.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunk.php

Loading...
Phabricator · Built by Phacility