Page MenuHomePhabricator
Differential D15368

Fix doubling of unbroken build steps in Build Plan view
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 12:38 AM
Unknown Object (File)
Fri, Apr 19, 4:16 PM
Unknown Object (File)
Thu, Apr 18, 2:27 PM
Unknown Object (File)
Tue, Apr 16, 12:25 AM
Unknown Object (File)
Fri, Apr 12, 4:06 PM
Unknown Object (File)
Thu, Apr 11, 10:11 AM
Unknown Object (File)
Mon, Apr 1, 3:50 PM
Unknown Object (File)
Fri, Mar 29, 6:14 PM
View All Files
Subscribers
None

Details

Reviewers
hach-que
tycho.tatitscheff
chad
Maniphest Tasks
T10479: Harbormaster build steps are duplicated in the UI
Commits
Restricted Diffusion Commit
rP58cea0714bff: Fix doubling of unbroken build steps in Build Plan view
Summary

Fixes T10479.

Test Plan

Viewed a valid build plan.

Diff Detail

Repository
rP Phabricator
Branch
dry12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10897
Build 13446: Run Core Tests
Build 13445: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37057.Mar 1 2016, 1:48 PM
epriestley retitled this revision from to Fix doubling of unbroken build steps in Build Plan view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que, tycho.tatitscheff.
epriestley added a task: T10479: Harbormaster build steps are duplicated in the UI.
epriestley mentioned this in T10479: Harbormaster build steps are duplicated in the UI.Mar 1 2016, 2:17 PM
chad accepted this revision.Mar 1 2016, 2:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 2:44 PM
Closed by commit rP58cea0714bff: Fix doubling of unbroken build steps in Build Plan view (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.
tycho.tatitscheff added inline comments.Mar 1 2016, 4:15 PM
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
116

Surely my missunderstanding but why isn't this $step_list->addItem()` deleted insead.
Or maybe it is the same ?

epriestley added inline comments.Mar 1 2016, 7:34 PM
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
129

The second one does not execute for invalid steps.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
2 lines

Diff 37057

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
Phabricator · Built by Phacility