Page MenuHomePhabricator
Differential D15362

Begin making Harbormaster unit test results a little easier to read
ClosedPublic
Actions

Authored by epriestley on Feb 29 2016, 2:17 PM.
Tags
None
Referenced Files
F13059440: D15362.diff
Fri, Apr 19, 4:15 PM
Unknown Object (File)
Sun, Apr 14, 9:08 AM
Unknown Object (File)
Thu, Apr 11, 7:43 AM
Unknown Object (File)
Mon, Apr 1, 3:50 PM
Unknown Object (File)
Thu, Mar 21, 10:28 PM
Unknown Object (File)
Thu, Mar 21, 10:13 PM
Unknown Object (File)
Thu, Mar 21, 10:09 PM
Unknown Object (File)
Thu, Mar 21, 7:49 PM
View All Files
Subscribers
None
Tokens
"Love" token, awarded by tycho.tatitscheff."Like" token, awarded by cburroughs.

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rP3c19b72ca0c8: Begin making Harbormaster unit test results a little easier to read
Summary

Ref T10457. These lack color and iconography and are difficult to parse. Make them easier to read.

Test Plan

Before:

Screen Shot 2016-02-29 at 5.34.49 AM.png (1×2 px, 292 KB)

After:

Screen Shot 2016-02-29 at 6.14.43 AM.png (1×1 px, 183 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10882
Build 13420: Run Core Tests
Build 13419: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37042.Feb 29 2016, 2:17 PM
epriestley retitled this revision from to Begin making Harbormaster unit test results a little easier to read.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
cburroughs awarded a token.Feb 29 2016, 2:29 PM
chad accepted this revision.Feb 29 2016, 3:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 29 2016, 3:15 PM
tycho.tatitscheff awarded a token.Feb 29 2016, 3:24 PM
Closed by commit rP3c19b72ca0c8: Begin making Harbormaster unit test results a little easier to read (authored by epriestley, committed by epriestley). · Explain WhyFeb 29 2016, 10:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
customfield/
66 lines
harbormaster/
constants/
89 lines
controller/
23 lines
storage/
build/
13 lines
view/
75 lines

Diff 37042

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/harbormaster/constants/HarbormasterUnitStatus.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitPropertyView.php

Loading...
Phabricator · Built by Phacility