Page MenuHomePhabricator
Differential D15355

Slightly improve Buildable list in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Feb 26 2016, 8:23 PM.
Tags
None
Referenced Files
F18835705: D15355.diff
Sun, Oct 26, 6:09 PM
F18827855: D15355.id.diff
Fri, Oct 24, 12:33 PM
F18823281: D15355.diff
Thu, Oct 23, 11:08 AM
F18743623: D15355.id37027.diff
Fri, Oct 3, 12:18 AM
F18671118: D15355.id37027.diff
Sep 25 2025, 2:44 AM
F18651677: D15355.diff
Sep 21 2025, 5:02 AM
F18629839: D15355.id37027.diff
Sep 16 2025, 10:02 AM
F18624415: D15355.id.diff
Sep 15 2025, 7:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rPfdca684814da: Slightly improve Buildable list in Harbormaster
Summary

Ref T10457. This makes diffs/revisions show the revision as the buildable title, and commits show the commit as the title.

Previously, the title was "Buildable X".

Also makes icons/colors/labels more consitent.

Test Plan

Screen Shot 2016-02-26 at 12.20.32 PM.png (257×554 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10864
Build 13395: Run Core Tests
Build 13394: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37027.Feb 26 2016, 8:23 PM
epriestley retitled this revision from to Slightly improve Buildable list in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
chad accepted this revision.Feb 26 2016, 8:38 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Feb 26 2016, 8:38 PM
epriestley added a comment.Feb 26 2016, 8:43 PM

Haha, we need an itsacceptable.

Closed by commit rPfdca684814da: Slightly improve Buildable list in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
9 lines
4 lines
harbormaster/
interface/
13 lines
query/
30 lines
storage/
4 lines
repository/
storage/
4 lines

Diff 37027

View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
Phabricator · Built by Phacility