Page MenuHomePhabricator
Differential D15354

Remove buildable handle / container handle logic form Harbormaster buildable queries
ClosedPublic
Actions

Authored by epriestley on Feb 26 2016, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:12 AM
Unknown Object (File)
Thu, Dec 12, 7:32 AM
Unknown Object (File)
Thu, Dec 12, 6:36 AM
Unknown Object (File)
Sun, Dec 8, 12:01 AM
Unknown Object (File)
Wed, Dec 4, 10:40 PM
Unknown Object (File)
Wed, Dec 4, 12:00 AM
Unknown Object (File)
Sat, Nov 30, 1:05 PM
Unknown Object (File)
Mon, Nov 25, 11:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rP220ac48801a1: Remove buildable handle / container handle logic form Harbormaster buildable…
Summary

Ref T10457. We currently have these weird, out-of-place methods on Harbormaster queries that just load handles. These were written before HandlePool, and HandlePool is now more convenient, simpler, and more efficient.

Drop this stuff in favor of using handle pools off $viewer.

Test Plan

Looked at buildable list, looked at buildable detail, grepped for removed methods.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37026.Feb 26 2016, 8:05 PM
epriestley retitled this revision from to Remove buildable handle / container handle logic form Harbormaster buildable queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
chad accepted this revision.Feb 26 2016, 8:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 8:56 PM
Closed by commit rP220ac48801a1: Remove buildable handle / container handle logic form Harbormaster buildable… (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37030

View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
Phabricator · Built by Phacility