Page MenuHomePhabricator

Remove buildable handle / container handle logic form Harbormaster buildable queries
ClosedPublic

Authored by epriestley on Feb 26 2016, 8:05 PM.

Details

Summary

Ref T10457. We currently have these weird, out-of-place methods on Harbormaster queries that just load handles. These were written before HandlePool, and HandlePool is now more convenient, simpler, and more efficient.

Drop this stuff in favor of using handle pools off $viewer.

Test Plan

Looked at buildable list, looked at buildable detail, grepped for removed methods.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove buildable handle / container handle logic form Harbormaster buildable queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 8:56 PM
This revision was automatically updated to reflect the committed changes.