Page MenuHomePhabricator
Differential D15334

Sort Spaces dropdown by name, not "alphabetical ID"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2016, 6:31 PM.
Tags
None
Referenced Files
F15455306: D15334.id36984.diff
Sat, Mar 29, 11:27 PM
F15450598: D15334.id36983.diff
Fri, Mar 28, 4:33 PM
F15450401: D15334.id.diff
Fri, Mar 28, 3:30 PM
F15446208: D15334.diff
Thu, Mar 27, 5:43 PM
F15437269: D15334.id36983.diff
Tue, Mar 25, 6:39 PM
F15406726: D15334.id36984.diff
Tue, Mar 18, 1:36 PM
F15382540: D15334.id36983.diff
Fri, Mar 14, 12:56 PM
Unknown Object (File)
Mar 2 2025, 7:00 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10414: No natural sort on space dropdown
Commits
Restricted Diffusion Commit
rPa112bc5cbaf0: Sort Spaces dropdown by name, not "alphabetical ID"
Summary

Fixes T10414. I think this sorted by name at one time (the asort()) but then I probably added "Space SX" in front of it. Or I just got this wrong from the beginning.

Instead, sort by space name.

Test Plan

Screen Shot 2016-02-23 at 10.29.58 AM.png (156×402 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
ssort
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10823
Build 13337: Run Core Tests
Build 13336: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36983.Feb 23 2016, 6:31 PM
epriestley retitled this revision from to Sort Spaces dropdown by name, not "alphabetical ID".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10414: No natural sort on space dropdown.
chad accepted this revision.Feb 23 2016, 6:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 6:41 PM
Closed by commit rPa112bc5cbaf0: Sort Spaces dropdown by name, not "alphabetical ID" (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2016, 6:41 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
src/
applications/
spaces/
query/
2 lines

Diff 36983

View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

Loading...
Phabricator · Built by Phacility