Page MenuHomePhabricator
Differential D15334

Sort Spaces dropdown by name, not "alphabetical ID"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2016, 6:31 PM.
Tags
None
Referenced Files
F13157045: D15334.diff
Sun, May 5, 8:44 AM
Unknown Object (File)
Fri, May 3, 9:43 AM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Unknown Object (File)
Sat, Apr 13, 8:53 PM
Unknown Object (File)
Sat, Apr 13, 6:09 PM
Unknown Object (File)
Thu, Apr 11, 10:42 AM
Unknown Object (File)
Apr 1 2024, 10:22 AM
Unknown Object (File)
Mar 31 2024, 5:02 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10414: No natural sort on space dropdown
Commits
Restricted Diffusion Commit
rPa112bc5cbaf0: Sort Spaces dropdown by name, not "alphabetical ID"
Summary

Fixes T10414. I think this sorted by name at one time (the asort()) but then I probably added "Space SX" in front of it. Or I just got this wrong from the beginning.

Instead, sort by space name.

Test Plan

Screen Shot 2016-02-23 at 10.29.58 AM.png (156×402 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
ssort
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10823
Build 13337: Run Core Tests
Build 13336: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36983.Feb 23 2016, 6:31 PM
epriestley retitled this revision from to Sort Spaces dropdown by name, not "alphabetical ID".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10414: No natural sort on space dropdown.
chad accepted this revision.Feb 23 2016, 6:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 6:41 PM
Closed by commit rPa112bc5cbaf0: Sort Spaces dropdown by name, not "alphabetical ID" (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2016, 6:41 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
src/
applications/
spaces/
query/
2 lines

Diff 36983

View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

Loading...
Phabricator · Built by Phacility