Page MenuHomePhabricator
Differential D15292

Add setHeader to PHUITwoColumnView for consistent page layouts
ClosedPublic
Actions

Authored by chad on Feb 17 2016, 9:06 PM.
Tags
None
Referenced Files
F14397757: D15292.diff
Sun, Dec 22, 12:00 PM
Unknown Object (File)
Sat, Dec 14, 4:23 PM
Unknown Object (File)
Thu, Dec 12, 11:53 AM
Unknown Object (File)
Sat, Dec 7, 3:54 PM
Unknown Object (File)
Sat, Dec 7, 2:13 PM
Unknown Object (File)
Wed, Dec 4, 6:43 AM
Unknown Object (File)
Fri, Nov 29, 12:22 PM
Unknown Object (File)
Thu, Nov 28, 5:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf5e2f9587c5e: Add setHeader to PHUITwoColumnView for consistent page layouts
Summary

Working towards making PHUITwoColumnView into a page layout engine. Adds header support.

Test Plan

Use new header on Profile and Profiles. No visual changes, less duplicated code.

Diff Detail

Repository
rP Phabricator
Branch
two-column-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10735
Build 13204: Run Core Tests
Build 13203: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36892.Feb 17 2016, 9:06 PM
chad retitled this revision from to Add setHeader to PHUITwoColumnView for consistent page layouts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 17 2016, 9:06 PM
epriestley accepted this revision.Feb 17 2016, 9:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2016, 9:07 PM
Closed by commit rPf5e2f9587c5e: Add setHeader to PHUITwoColumnView for consistent page layouts (authored by chad, committed by chad). · Explain WhyFeb 17 2016, 9:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
people/
controller/
18 lines
project/
controller/
16 lines
view/
phui/
17 lines
webroot/
rsrc/
css/
application/
project/
2 lines
phui/
2 lines

Diff 36892

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/application/project/project-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility