Page MenuHomePhabricator

Fix limit calculation for largeish Mercurial repsositories
ClosedPublic

Authored by epriestley on Feb 16 2016, 10:02 PM.
Tags
None
Referenced Files
F15479300: D15282.diff
Tue, Apr 8, 6:04 AM
F15476891: D15282.id36871.diff
Mon, Apr 7, 9:58 AM
F15469492: D15282.id36871.diff
Fri, Apr 4, 1:38 PM
F15463468: D15282.id36871.diff
Tue, Apr 1, 11:50 PM
F15452098: D15282.id36871.diff
Sat, Mar 29, 1:45 AM
F15441155: D15282.id36871.diff
Wed, Mar 26, 4:42 PM
F15437249: D15282.id36871.diff
Tue, Mar 25, 6:33 PM
F15426237: D15282.id36871.diff
Sun, Mar 23, 7:49 AM
Subscribers

Details

Summary

Fixes T10304. In Mercurial, we must enumerate the whole file tree. Currently, we incorrectly count files within directories (which won't be shown) toward the "100 file" limit at top level, so directories with more than 100 subpaths are truncated improperly.

This is approxiately the same as @richardvanvelzen's fix.

Test Plan

Viewed a large Mercurial repository, saw a complete directory listing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix limit calculation for largeish Mercurial repsositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: richardvanvelzen.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2016, 10:05 PM
This revision was automatically updated to reflect the committed changes.