Differential D15274

Improve subproject/milestone error handling for users who can't create projects
ClosedPublic
Actions

Authored by epriestley on Feb 15 2016, 3:22 PM.

Tags

None

Referenced Files

	F15487757: D15274.id36853.diff
	Thu, Apr 10, 4:50 PM

	F15482392: D15274.id36852.diff
	Wed, Apr 9, 5:11 AM

	F15481063: D15274.id.diff
	Tue, Apr 8, 5:54 PM

	F15476212: D15274.diff
	Mon, Apr 7, 4:41 AM

	F15457681: D15274.diff
	Sun, Mar 30, 5:44 PM

	F15394349: D15274.id36853.diff
	Sat, Mar 15, 11:49 PM

	F15394348: D15274.id36852.diff
	Sat, Mar 15, 11:49 PM

	F15394347: D15274.id.diff
	Sat, Mar 15, 11:49 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10357: Adding milestones or subproject for non administrator show Unknown Object

Commits

Restricted Diffusion Commit
rPf1f8ee8e6ad5: Improve subproject/milestone error handling for users who can't create projects

Summary

Fixes T10357.

Show a better (more descriptive) error message when a user who can't create projects tries to create a subproject or milestone.
Disable the subproject actions if you don't have create permission.

All this stuff was already enforced properly: this diff doesn't make any actual policy changes, just improves the UI for users who lack permission.

Test Plan

As an unprivileged user (no "Can Create Projects"), tried to create a subproject or milestone.
After patch, got a disabled action, with more specific and helpful error than before.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36852.Feb 15 2016, 3:22 PM

epriestley retitled this revision from to Improve subproject/milestone error handling for users who can't create projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10357: Adding milestones or subproject for non administrator show Unknown Object.

epriestley mentioned this in T10357: Adding milestones or subproject for non administrator show Unknown Object.Feb 15 2016, 3:24 PM

chad accepted this revision.Feb 15 2016, 3:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 15 2016, 3:29 PM

Closed by commit rPf1f8ee8e6ad5: Improve subproject/milestone error handling for users who can't create projects (authored by epriestley, committed by epriestley). · Explain WhyFeb 15 2016, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectEditController.php

5 lines

PhabricatorProjectSubprojectsController.php

7 lines

Diff 36853

src/applications/project/controller/PhabricatorProjectEditController.php

Loading...

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...