Slightly better in modern code is to continue using AphrontFormView, then use appendForm() here.

I think there should be no more cases where PHUIFormLayoutView needs to be used directly.

This one is a little tricky. You probably either want:

• do all the work to preserve board state, plus do this; or
• don't do any of the work, and don't do this.

Specifically, the current behavior will probably be:

• change priority and filter on board;
• click "add column";
• click "cancel";
• page reloads, losing your sort/filter.

If you remove this, we'll no longer reload in the case above. However, you'll still lose your state when you actually add a column, or when you right-click-open-in-new-window the dialog and then cancel it.

To fix these, you need to do a lot more work to preserve state -- all the getPassthroughRequestData() stuff that controllers like PhabricatorProjectDefaultController and PhabricatorProjectColumnHideController do. In this case, because the controller also has real parameters of its own, things get more complex.

I think if you just delete this setDisablewWorkflowOnCancel() call for now things should be mostly OK, and I can go hook up all the passthrough stuff later if it's really an issue.