Page MenuHomePhabricator
Differential D15263

Put boundary spaces around crumb names so double-clicking doesn't flip out
ClosedPublic
Actions

Authored by epriestley on Feb 12 2016, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 7:46 PM
Unknown Object (File)
Fri, Jan 24, 11:48 AM
Unknown Object (File)
Fri, Jan 24, 11:48 AM
Unknown Object (File)
Fri, Jan 24, 11:47 AM
Unknown Object (File)
Tue, Jan 14, 5:07 PM
Unknown Object (File)
Dec 10 2024, 4:31 PM
Unknown Object (File)
Dec 8 2024, 8:38 PM
Unknown Object (File)
Dec 4 2024, 11:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPde4167d6832d: Put boundary spaces around crumb names so double-clicking doesn't flip out
Summary

Occasionally, double clicking crumbs to select them is useful.

Test Plan

Screen Shot 2016-02-12 at 11.09.59 AM.png (164×356 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
crumbbumper
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10672
Build 13108: Run Core Tests
Build 13107: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36830.Feb 12 2016, 7:11 PM
epriestley retitled this revision from to Put boundary spaces around crumb names so double-clicking doesn't flip out.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a comment.Feb 12 2016, 7:12 PM

This doesn't seem to do anything questionable (e.g., inject piles of whitespace) in any browser, and we do something similar in property lists successfully.

chad accepted this revision.Feb 12 2016, 7:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 7:13 PM
Closed by commit rPde4167d6832d: Put boundary spaces around crumb names so double-clicking doesn't flip out (authored by epriestley, committed by epriestley). · Explain WhyFeb 12 2016, 7:13 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM
epriestley mentioned this in T12043: Link task number and title for easier referencing via copy & paste.Dec 23 2016, 7:34 PM

Revision Contents
Changeset List

PathSize
src/
view/
phui/
6 lines

Diff 36830

View Options

src/view/phui/PHUICrumbView.php

Loading...
Phabricator · Built by Phacility