Page MenuHomePhabricator

Allow task statuses to have claiming disabled
ClosedPublic

Authored by epriestley on Feb 12 2016, 4:33 AM.
Tags
None
Referenced Files
F13320182: D15257.diff
Fri, Jun 14, 12:44 AM
F13310349: D15257.id.diff
Mon, Jun 10, 12:24 PM
F13299892: D15257.diff
Fri, Jun 7, 8:33 AM
F13294963: D15257.id.diff
Wed, Jun 5, 9:17 PM
F13294962: D15257.diff
Wed, Jun 5, 9:17 PM
F13294250: D15257.id36816.diff
Wed, Jun 5, 4:24 PM
F13294249: D15257.id36815.diff
Wed, Jun 5, 4:24 PM
F13282292: D15257.diff
Sun, Jun 2, 11:54 AM
Subscribers
None

Details

Summary

Fixes T10343. All solutions here seem basically fine. I think adding this small bit of complexity is OK, and sorrrrt of like this behavior sometimes.

  • Allow disabling this behavior per-status.
  • Disable it by default for "Invalid" and "Duplicate" (I left "wontfix", since that's a resolution?).

Beyond being more flexible, I think this is slightly better?

Test Plan
  • Closed a task as invalid: no claim.
  • Closed a task as resolved: claim.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow task statuses to have claiming disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I ended up here mostly because I suspect I'd actually miss this for "Fixes X" in Differential if we fully removed it.

chad edited edge metadata.

haha, yeah I was thinking about this on my "put the baby to sleep" drive. Automagical seems best. This works well since attaching a diff with Fixes would also resolve and claim.

This revision is now accepted and ready to land.Feb 12 2016, 4:39 AM

Yeah. I don't tend to like magic, but this seems like a teeny tiny small magic and probably a better behavior overall, and I like that it makes it configurable without needing new top-level options.

This revision was automatically updated to reflect the committed changes.