Page MenuHomePhabricator

Allow task statuses to have claiming disabled
ClosedPublic

Authored by epriestley on Feb 12 2016, 4:33 AM.

Details

Summary

Fixes T10343. All solutions here seem basically fine. I think adding this small bit of complexity is OK, and sorrrrt of like this behavior sometimes.

  • Allow disabling this behavior per-status.
  • Disable it by default for "Invalid" and "Duplicate" (I left "wontfix", since that's a resolution?).

Beyond being more flexible, I think this is slightly better?

Test Plan
  • Closed a task as invalid: no claim.
  • Closed a task as resolved: claim.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 36815.Feb 12 2016, 4:33 AM
epriestley retitled this revision from to Allow task statuses to have claiming disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I ended up here mostly because I suspect I'd actually miss this for "Fixes X" in Differential if we fully removed it.

chad accepted this revision.Feb 12 2016, 4:39 AM
chad edited edge metadata.

haha, yeah I was thinking about this on my "put the baby to sleep" drive. Automagical seems best. This works well since attaching a diff with Fixes would also resolve and claim.

This revision is now accepted and ready to land.Feb 12 2016, 4:39 AM

Yeah. I don't tend to like magic, but this seems like a teeny tiny small magic and probably a better behavior overall, and I like that it makes it configurable without needing new top-level options.

This revision was automatically updated to reflect the committed changes.