Page MenuHomePhabricator
Differential D15242

Fix an issue with creating tasks directly into milestone columns
ClosedPublic
Actions

Authored by epriestley on Feb 11 2016, 5:52 PM.
Tags
None
Referenced Files
F15464257: D15242.diff
Wed, Apr 2, 7:52 AM
F15429527: D15242.diff
Mon, Mar 24, 2:49 AM
F15423496: D15242.diff
Sat, Mar 22, 3:42 PM
Unknown Object (File)
Feb 27 2025, 3:46 PM
Unknown Object (File)
Feb 26 2025, 3:30 AM
Unknown Object (File)
Feb 17 2025, 8:19 PM
Unknown Object (File)
Feb 9 2025, 12:44 AM
Unknown Object (File)
Feb 9 2025, 12:44 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPad77b014f10e: Fix an issue with creating tasks directly into milestone columns
Summary

These columns were conflating projectPHID (the defualt project to add to the task) with boardPHID (the board the column appears on).

Separate them to fix the beahvior.

Test Plan

Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36787.Feb 11 2016, 5:52 PM
epriestley retitled this revision from to Fix an issue with creating tasks directly into milestone columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Feb 11 2016, 5:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 5:54 PM
Closed by commit rPad77b014f10e: Fix an issue with creating tasks directly into milestone columns (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2016, 6:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
applications/
project/
controller/
1 line
webroot/
rsrc/
js/
application/
projects/
4 lines

Diff 36790

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

webroot/rsrc/js/application/projects/WorkboardController.js

Loading...
Phabricator · Built by Phacility