Ref T4427. This kind of works.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T4427: Add formal task points
- Commits
- Restricted Diffusion Commit
rP0782652a8059: Add a basic progress bar for milestones
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- board10
- Lint
Lint Passed Severity Location Code Message Advice src/applications/maniphest/editor/ManiphestEditEngine.php:322 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 10581 Build 12972: Run Core Tests Build 12971: arc lint + arc unit
Event Timeline
| src/applications/maniphest/editor/ManiphestEditEngine.php | ||
|---|---|---|
| 310 | This stuff isn't directly related, but if you inline-edit a task which only belongs to a column implicitly we currently error out. This fixes it, but overfetches. All the related code needs changes soon anyway to accommodate a bunch of live-edit bugs so I'll deal with it more surgically in future diffs. | |
Comment Actions
Do you think this needs to be a separate panel? I assumed it would just be baked into the profile panel.
Comment Actions
Seems somewhat useful to me to be able to hide/reorder it separately from the other items. It might also eventually get config, maybe.
Comment Actions
My concern is mostly around people being able to make bad UI choices though unlimited customization. I'm fine giving this a whirl, but we probably should think about some sort of "global" settings for profile menus, so people at least have some way of keeping things consistent. Consistently bad is at least better than randomly bad and confusing.