Page MenuHomePhabricator

Add a basic progress bar for milestones
ClosedPublic

Authored by epriestley on Feb 9 2016, 1:36 AM.
Tags
None
Referenced Files
F13099436: D15221.diff
Fri, Apr 26, 3:17 PM
Unknown Object (File)
Sun, Apr 21, 7:39 PM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Sun, Apr 14, 10:49 PM
Unknown Object (File)
Fri, Apr 12, 10:12 AM
Unknown Object (File)
Thu, Apr 11, 3:44 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4427: Add formal task points
Commits
Restricted Diffusion Commit
rP0782652a8059: Add a basic progress bar for milestones
Summary

Ref T4427. This kind of works.

Test Plan

Screen Shot 2016-02-08 at 5.32.55 PM.png (1×1 px, 110 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a basic progress bar for milestones.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/applications/maniphest/editor/ManiphestEditEngine.php
310

This stuff isn't directly related, but if you inline-edit a task which only belongs to a column implicitly we currently error out.

This fixes it, but overfetches.

All the related code needs changes soon anyway to accommodate a bunch of live-edit bugs so I'll deal with it more surgically in future diffs.

Do you think this needs to be a separate panel? I assumed it would just be baked into the profile panel.

Seems somewhat useful to me to be able to hide/reorder it separately from the other items. It might also eventually get config, maybe.

(I also think clicking it might take you to some sort of charts eventually.)

My concern is mostly around people being able to make bad UI choices though unlimited customization. I'm fine giving this a whirl, but we probably should think about some sort of "global" settings for profile menus, so people at least have some way of keeping things consistent. Consistently bad is at least better than randomly bad and confusing.

chad edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2016, 2:46 AM
This revision was automatically updated to reflect the committed changes.