Only prevent drag-scroll in the Y direction on workboards
ClosedPublic
Actions

Authored by epriestley on Feb 8 2016, 6:04 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rPd78061d820eb: Only prevent drag-scroll in the Y direction on workboards

Summary

This scroll lock thing prevented both X and Y scrolling, but should only prevent Y scrolling. Dragging a card to the edge to scroll left/right is fine.

Test Plan

Scrolled a workboard left/right by dragging a card to the edge.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36725.Feb 8 2016, 6:04 PM

epriestley retitled this revision from to Only prevent drag-scroll in the Y direction on workboards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Feb 8 2016, 6:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 8 2016, 6:05 PM

Closed by commit rPd78061d820eb: Only prevent drag-scroll in the Y direction on workboards (authored by epriestley, committed by epriestley). · Explain WhyFeb 8 2016, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

src/

view/

phui/

PHUIWorkboardView.php

2 lines

webroot/

rsrc/

js/

core/

DraggableList.js

11 lines

Diff 36726

View Options

resources/celerity/map.php

View Options

src/view/phui/PHUIWorkboardView.php

View Options

webroot/rsrc/js/core/DraggableList.js

Only prevent drag-scroll in the Y direction on workboardsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36726

resources/celerity/map.php

src/view/phui/PHUIWorkboardView.php

webroot/rsrc/js/core/DraggableList.js

Only prevent drag-scroll in the Y direction on workboards
ClosedPublic
Actions

Revision Contents
Changeset List