Page MenuHomePhabricator
Differential D15213

Only prevent drag-scroll in the Y direction on workboards
ClosedPublic
Actions

Authored by epriestley on Feb 8 2016, 6:04 PM.
Tags
None
Referenced Files
F13162972: D15213.diff
Mon, May 6, 4:54 PM
Unknown Object (File)
Fri, May 3, 3:58 AM
Unknown Object (File)
Mon, Apr 29, 4:08 PM
Unknown Object (File)
Wed, Apr 24, 11:55 PM
Unknown Object (File)
Tue, Apr 16, 9:54 PM
Unknown Object (File)
Thu, Apr 11, 5:33 PM
Unknown Object (File)
Thu, Apr 11, 8:12 AM
Unknown Object (File)
Feb 9 2024, 10:38 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPd78061d820eb: Only prevent drag-scroll in the Y direction on workboards
Summary

This scroll lock thing prevented both X and Y scrolling, but should only prevent Y scrolling. Dragging a card to the edge to scroll left/right is fine.

Test Plan

Scrolled a workboard left/right by dragging a card to the edge.

Diff Detail

Repository
rP Phabricator
Branch
board4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10565
Build 12947: Run Core Tests
Build 12946: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36725.Feb 8 2016, 6:04 PM
epriestley retitled this revision from to Only prevent drag-scroll in the Y direction on workboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Feb 8 2016, 6:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 8 2016, 6:05 PM
Closed by commit rPd78061d820eb: Only prevent drag-scroll in the Y direction on workboards (authored by epriestley, committed by epriestley). · Explain WhyFeb 8 2016, 6:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
view/
phui/
2 lines
webroot/
rsrc/
js/
core/
11 lines

Diff 36725

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIWorkboardView.php

Loading...
View Options

webroot/rsrc/js/core/DraggableList.js

Loading...
Phabricator · Built by Phacility