Page MenuHomePhabricator
Differential D15204

Link proxy column headers on workboards to proxied projects
ClosedPublic
Actions

Authored by epriestley on Feb 7 2016, 12:26 AM.
Tags
None
Referenced Files
F13180606: D15204.id36704.diff
Thu, May 9, 1:21 AM
Unknown Object (File)
Tue, May 7, 5:33 AM
Unknown Object (File)
Mon, May 6, 4:27 AM
Unknown Object (File)
Fri, May 3, 3:18 AM
Unknown Object (File)
Wed, May 1, 10:16 PM
Unknown Object (File)
Mon, Apr 29, 2:44 PM
Unknown Object (File)
Sun, Apr 28, 11:32 AM
Unknown Object (File)
Wed, Apr 24, 10:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rPa45fe337a12f: Link proxy column headers on workboards to proxied projects
Summary

Ref T10010. Allows you to click "Milestone 99" to jump directly to that project.

Test Plan
  • Clicked milestone header, went to milestone.
  • Clicked normal column header, nothing happened. Wow!

Diff Detail

Repository
rP Phabricator
Branch
colhref
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10544
Build 12917: Run Core Tests
Build 12916: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36703.Feb 7 2016, 12:26 AM
epriestley retitled this revision from to Link proxy column headers on workboards to proxied projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10010: Implement Subprojects.
chad accepted this revision.Feb 7 2016, 12:28 AM
chad edited edge metadata.

Doesn't headerview take an href?

This revision is now accepted and ready to land.Feb 7 2016, 12:28 AM
epriestley added a comment.Feb 7 2016, 12:29 AM

Image HREF only. I could push this down.

epriestley updated this revision to Diff 36704.Feb 7 2016, 12:32 AM
epriestley edited edge metadata.
  • Push down.

The hover state on this is a little unusual-ish, maybe (it's picking up blue from something, which looks odd on the purple background?) but I am conveniently pretending I didn't see it.

Closed by commit rPa45fe337a12f: Link proxy column headers on workboards to proxied projects (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2016, 12:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
7 lines
view/
phui/
23 lines

Diff 36703

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
Phabricator · Built by Phacility