Differential D15203

Scale up small cover images instead of surrounding them with empty space
ClosedPublic
Actions

Authored by epriestley on Feb 7 2016, 12:08 AM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP4974e8487b9f: Scale up small cover images instead of surrounding them with empty space

Summary

This makes small cover images full-width instead of teeny tiny dots in the middle of an island of whitespace.

Test Plan

Uploaded a small cover image.

Diff Detail

Repository

rP Phabricator

Branch

cover3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10542
Build 12914: Run Core Tests
Build 12913: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36701.Feb 7 2016, 12:08 AM

epriestley retitled this revision from to Scale up small cover images instead of surrounding them with empty space.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Feb 7 2016, 12:09 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 7 2016, 12:09 AM

Before:

Screen Shot 2016-02-06 at 4.08.54 PM.png (152×311 px, 13 KB)

After:

Screen Shot 2016-02-06 at 4.08.58 PM.png (144×315 px, 19 KB)

Closed by commit rP4974e8487b9f: Scale up small cover images instead of surrounding them with empty space (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2016, 12:09 AM

This revision was automatically updated to reflect the committed changes.

Where's the rest of the card?

You mean the missing projects/etc?

"After" is just a task on my local install with no projects or owner.

itsmagic

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

transform/

PhabricatorFileThumbnailTransform.php

1 line

Diff 36701

View Options

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Scale up small cover images instead of surrounding them with empty spaceClosedPublicActions