Page MenuHomePhabricator
Differential D15167

Implement subproject/milestone conflict resolution rules
ClosedPublic
Actions

Authored by epriestley on Feb 2 2016, 9:07 PM.
Tags
None
Referenced Files
F14351738: D15167.id36618.diff
Thu, Dec 19, 9:56 AM
Unknown Object (File)
Wed, Dec 11, 11:03 PM
Unknown Object (File)
Sat, Dec 7, 1:43 AM
Unknown Object (File)
Thu, Nov 21, 1:12 PM
Unknown Object (File)
Nov 18 2024, 8:41 PM
Unknown Object (File)
Nov 14 2024, 7:38 AM
Unknown Object (File)
Nov 14 2024, 4:30 AM
Unknown Object (File)
Nov 13 2024, 12:27 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rP268a9ced78da: Implement subproject/milestone conflict resolution rules
Summary

Ref T10010. When you try to add "Sprint 35" to a task, remove "Sprint 34", etc. Briefly:

  • A task can't be in Sprint 3 and Sprint 4.
  • A task can't be in "A" and "A > B" (but "A > B" and "A > C" are fine).
  • When a user makes an edit which would violate one of these rules, preserve the last tag in each group of conflicts.
Test Plan
  • Added fairly comprehensive tests.
  • Added a bunch of different tags to things, saw them properly exclude conflicting tags.

Diff Detail

Repository
rP Phabricator
Branch
col1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10460
Build 12788: Run Core Tests
Build 12787: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36618.Feb 2 2016, 9:07 PM
epriestley retitled this revision from to Implement subproject/milestone conflict resolution rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10010: Implement Subprojects.
chad accepted this revision.Feb 2 2016, 9:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2016, 9:10 PM
epriestley added a comment.Feb 2 2016, 9:12 PM

One possible weird consequence of these rules is that these tags are OK:

  • (Stonework → Iteration IV) + (Stonework → Masonry)

I think that's fine for now. If it ultimately turns out to be confusing, we could make adding Stonework → Masonry remove Stonework → Milestone X.

Closed by commit rP268a9ced78da: Implement subproject/milestone conflict resolution rules (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2016, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
__tests__/
132 lines
transactions/
editor/
133 lines
docs/
user/
userguide/
34 lines

Diff 36618

View Options

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/docs/user/userguide/projects.diviner

Loading...
Phabricator · Built by Phacility