Page MenuHomePhabricator

Improve minor workboard drag behaviors
ClosedPublic

Authored by epriestley on Feb 2 2016, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:33 AM
Unknown Object (File)
Fri, Nov 22, 4:28 PM
Unknown Object (File)
Thu, Nov 21, 10:11 AM
Unknown Object (File)
Mon, Nov 18, 11:14 AM
Unknown Object (File)
Thu, Nov 14, 5:26 AM
Unknown Object (File)
Wed, Nov 13, 1:09 AM
Unknown Object (File)
Sun, Nov 10, 2:02 PM
Unknown Object (File)
Wed, Nov 6, 5:49 AM
Subscribers

Details

Summary

Ref T5240.

  • Add proper class when dropping cards.
  • Add proper class when creating new cards.
  • Make X-drag explicit so that it works if there's only one column.
  • Stop tootips when dragging, resume them after dropping.
  • Move CSS rule for consistency.
  • Allow user to hit "Escape" to cancel an in-progress drag.
Test Plan
  • Dropped cards.
  • Created new cards.
  • X-dragged on a workboard with one column and a dashboard.
  • Dragged over a tooltip (no tip), dropped, moused over tooltip (tip).
  • Hit escape during a drag.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve minor workboard drag behaviors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Allow user to hit "Escape" to cancel an in-progress drag.

chad edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2016, 2:42 PM
This revision was automatically updated to reflect the committed changes.