Don't render anything on project homepages if there are no properties at all
ClosedPublic
Actions

Authored by epriestley on Jan 24 2016, 1:15 AM.

Details

Reviewers

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP710fc0ce7ff9: Don't render anything on project homepages if there are no properties at all

Summary

Ref T10054.

Test Plan

Screen Shot 2016-01-23 at 5.14.14 PM.png (989×1 px, 169 KB)

Also looked at a project which did have stuff to make sure the stuff still worked.

Diff Detail

Repository

rP Phabricator

Branch

nostuff

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10301
Build 12545: Run Core Tests
Build 12544: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36463.Jan 24 2016, 1:15 AM

epriestley retitled this revision from to Don't render anything on project homepages if there are no properties at all.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

chad accepted this revision.Jan 24 2016, 1:18 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 24 2016, 1:18 AM

Closed by commit rP710fc0ce7ff9: Don't render anything on project homepages if there are no properties at all (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2016, 1:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectProfileController.php

5 lines

view/

phui/

PHUIPropertyListView.php

10 lines

Diff 36463

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php