Page MenuHomePhabricator
Differential D15096

Fix text for Passphrase credential destruction transaction when restoring credentials
ClosedPublic
Actions

Authored by epriestley on Jan 23 2016, 8:20 PM.
Tags
None
Referenced Files
F13231344: D15096.diff
Tue, May 21, 12:24 AM
F13213152: D15096.diff
Fri, May 17, 7:27 AM
Unknown Object (File)
Tue, May 7, 5:18 AM
Unknown Object (File)
Fri, May 3, 2:40 AM
Unknown Object (File)
Wed, May 1, 11:36 PM
Unknown Object (File)
Wed, May 1, 11:36 PM
Unknown Object (File)
Mon, Apr 29, 2:13 PM
Unknown Object (File)
Wed, Apr 24, 10:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10211: wrong text, if you recreate a destroyed credential
Commits
Restricted Diffusion Commit
rP0b4ed94cc6ad: Fix text for Passphrase credential destruction transaction when restoring…
Summary

Fixes T10211. This transaction can either be setting or removing the "destroyed" flag, but we show "destroyed" in both cases.

Instead, if the transaction is clearing the flag, render "restored".

Test Plan

Screen Shot 2016-01-23 at 12.17.59 PM.png (139×399 px, 16 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36448.Jan 23 2016, 8:20 PM
epriestley retitled this revision from to Fix text for Passphrase credential destruction transaction when restoring credentials.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10211: wrong text, if you recreate a destroyed credential.
epriestley planned changes to this revision.Jan 23 2016, 8:21 PM

Actually, I kind of don't like this because I think the text implies that you revived the secret, too, which you did not (the secret is truly gone forever).

Maybe I'll just hide this transaction instead if I can't come up with some better text.

epriestley updated this revision to Diff 36449.Jan 23 2016, 8:24 PM
  • Adjust phrasing to talk about destroying, attaching and updating secrets. I think this is a little more clear.

Screen Shot 2016-01-23 at 12.23.46 PM.png (91×395 px, 13 KB)

chad accepted this revision.Jan 23 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2016, 8:25 PM
Closed by commit rP0b4ed94cc6ad: Fix text for Passphrase credential destruction transaction when restoring… (authored by epriestley, committed by epriestley). · Explain WhyJan 23 2016, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
storage/
21 lines

Diff 36450

View Options

src/applications/passphrase/storage/PassphraseCredentialTransaction.php

Loading...
Phabricator · Built by Phacility