Paths

Table of Contentst

Fix an issue where the first click on the profile menu collapse link could be swallowed
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 12:04 PM.

Tags

None

Referenced Files

	F14011127: D15087.id36437.diff
	Thu, Oct 31, 6:49 PM

	F14005722: D15087.id36428.diff
	Sun, Oct 27, 6:16 PM

	F13976698: D15087.id36437.diff
	Oct 18 2024, 3:20 PM

	F13975209: D15087.id.diff
	Oct 18 2024, 9:13 AM

	Unknown Object (File)
	Sep 30 2024, 5:51 PM

	Unknown Object (File)
	Sep 24 2024, 8:08 AM

	Unknown Object (File)
	Sep 11 2024, 7:09 PM

	Unknown Object (File)
	Sep 11 2024, 7:09 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be…

Summary

alterClass() is strict about true/false but we set 0/1 elsewhere.

Test Plan

Collapsed/expanded menu, reloaded expanded menu, clicked collapse, got immediate collapse.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36428.Jan 22 2016, 12:04 PM

epriestley retitled this revision from to Fix an issue where the first click on the profile menu collapse link could be swallowed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Jan 22 2016, 2:51 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 2:51 PM

Closed by commit rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be… (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfilePanelEngine.php

2 lines

Diff 36437

View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Fix an issue where the first click on the profile menu collapse link could be swallowedClosedPublicActions