Page MenuHomePhabricator

Fix an issue where the first click on the profile menu collapse link could be swallowed
ClosedPublic

Authored by epriestley on Jan 22 2016, 12:04 PM.
Tags
None
Referenced Files
F13216699: D15087.diff
Sat, May 18, 1:54 AM
F13206016: D15087.id36437.diff
Wed, May 15, 4:38 AM
F13200516: D15087.diff
Tue, May 14, 1:02 AM
F13200288: D15087.diff
Mon, May 13, 10:52 PM
Unknown Object (File)
Sat, May 4, 7:06 AM
Unknown Object (File)
Fri, Apr 26, 2:51 PM
Unknown Object (File)
Fri, Apr 26, 3:07 AM
Unknown Object (File)
Apr 17 2024, 3:13 PM
Subscribers
None

Details

Summary

alterClass() is strict about true/false but we set 0/1 elsewhere.

Test Plan

Collapsed/expanded menu, reloaded expanded menu, clicked collapse, got immediate collapse.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue where the first click on the profile menu collapse link could be swallowed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.