Spiffy up new sidebar, simplify UI
ClosedPublic
Actions

Authored by chad on Jan 21 2016, 10:00 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP6a701c198843: Spiffy up new sidebar, simplify UI

Summary

Mostly a visual spacing pass, also adds in circle icons for edit, collapse. For now removing the fixed position on the icons for simplicity while the basics are being polished.

Test Plan

Projects, Profiles, wide and narrow.

Diff Detail

Repository

rP Phabricator

Branch

sidebar-1 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10248
Build 12464: Run Core Tests
Build 12463: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36411.Jan 21 2016, 10:00 PM

chad retitled this revision from to Spiffy up new sidebar, simplify UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 21 2016, 10:00 PM

epriestley accepted this revision.Jan 21 2016, 10:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 10:01 PM

where does the narrow workboard width get set?

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
206	I moved this to 88 so it has some symmetry with the header at 44.

Workboard junk is these in phui-workboard-view.css, I believe:

.device-desktop .project-board-wrapper .phui-workboard-view-shadow {
  left: 253px;
}

.device-desktop .phui-profile-menu-collapsed .project-board-wrapper
  .phui-workboard-view-shadow {
  left: 93px;
}