Page MenuHomePhabricator

Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if the user has no access to databases
ClosedPublic

Authored by epriestley on Jan 21 2016, 9:04 PM.
Tags
None
Referenced Files
F15450936: D15079.id36409.diff
Fri, Mar 28, 7:11 PM
F15443920: D15079.id.diff
Thu, Mar 27, 6:55 AM
F15443614: D15079.id36407.diff
Thu, Mar 27, 5:16 AM
F15440693: D15079.diff
Wed, Mar 26, 2:10 PM
F15399297: D15079.id.diff
Mon, Mar 17, 3:51 AM
F15394286: D15079.id.diff
Sat, Mar 15, 11:46 PM
F15389869: D15079.id36409.diff
Sat, Mar 15, 5:43 AM
F15387921: D15079.diff
Sat, Mar 15, 3:06 AM
Subscribers
None

Details

Summary

Ref T10195. Distinguish between "database does not exist" and "database exists, you just don't have permission to access it".

We can't easily get this information out of INFORMATION_SCHEMA but can just SHOW TABLES IN ... every database that looks like it's missing and then look at the error code.

Test Plan
  • Created a user limited with limited access.
  • Ran bin/storage adjust.
  • Got hopefully more helpful messages about access problems, instead of "Missing" errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if the user has no access to databases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 21 2016, 9:05 PM
This revision was automatically updated to reflect the committed changes.