Differential D15075

Add a missing key to HarbormasterBuildArtifact
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 6:19 PM.

Details

Reviewers

chad

Maniphest Tasks

T10192: HarbormasterBuildArtifact should have an index on buildTargetPHID

Commits

Restricted Diffusion Commit
rP6ebe8db3809f: Add a missing key to HarbormasterBuildArtifact

Summary

Fixes T10192. This key improves some common queries and is not currently present.

Test Plan

See discussion in T10192. Verified current query plan of real queries is garbage and improved by adding this key.

Diff Detail

Repository

rP Phabricator

Branch

hartifact1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10236
Build 12445: Run Core Tests
Build 12444: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36400.Jan 21 2016, 6:19 PM

epriestley retitled this revision from to Add a missing key to HarbormasterBuildArtifact.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10192: HarbormasterBuildArtifact should have an index on buildTargetPHID.

chad accepted this revision.Jan 21 2016, 6:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 6:19 PM

Closed by commit rP6ebe8db3809f: Add a missing key to HarbormasterBuildArtifact (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 6:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildArtifact.php

3 lines

Diff 36400

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

Add a missing key to HarbormasterBuildArtifactClosedPublicActions