Update project profile image composer for new IconSet code
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 10:05 PM.

Details

Reviewers

chad

Maniphest Tasks

T6856: Make Project Images that match Typeahead choices
T10164: Clicking "Use Project Icon" 404's

Commits

Restricted Diffusion Commit
rPa9a5991f010d: Update project profile image composer for new IconSet code

Summary

Fixes T6856. Fixes T10164.

Make the profile image composer code use the underlying icon name instead of the top-level icon key, so it works instead of 404'ing.
Change the button to show a preview of the profile icon instead of the text "Use Icon and Color".
When creating a new non-milestone project, automatically set the profile image to the icon + color image.

Test Plan

Created several new projects, saw appropriate default icons.
Edited projects, saw icon previews.
Clicked icon buttons to set icons.
Poked around other applications which use builtins (Pholio, user profiles) to look for anything I broke, but everything seemed fine.

Diff Detail

Repository

rP Phabricator

Branch

pm1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10182
Build 12363: Run Core Tests
Build 12362: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36347.Jan 18 2016, 10:05 PM

epriestley retitled this revision from to Update project profile image composer for new IconSet code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10164: Clicking "Use Project Icon" 404's, T6856: Make Project Images that match Typeahead choices.

Screen Shot 2016-01-18 at 2.06.55 PM.png (1×1 px, 197 KB)

That build failure is because gd is not installed on the build tier, I'll get it installed.

I updated the deployment scripts to install php5-gd on all tiers, since some obscure build/repo jobs need them.
I deployed sbuild001.
I restarted the build, and it's now green.

itsawesome

This revision is now accepted and ready to land.Jan 18 2016, 11:07 PM

One minor thing is that the icons are now configurable, but we don't have 2x sprites for all of them, so the default may end up picking a generic icon (currently, an umbrella) if you, say, add fa-rebel as a Project icon. We can probably cross that bridge when we come to it, unless you have some super efficient process for automatically generating all 2000 other 2x PNGs.

Closed by commit rPa9a5991f010d: Update project profile image composer for new IconSet code (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 11:09 PM

This revision was automatically updated to reflect the committed changes.

I presumed these were no longer going to be images, but bg-color + fonticon.

T6856 specifically was about making these fonts over images.

It's probably less work to just automate the icon slicing than special case all the rendering code.

I can probably dig up all the font awesome icons as pngs, is that what you need?

If it takes you like ~10 minutes, yeah. If it takes you more than that, don't bother and I'll build some kind of automated pipeline for it sooner or later.

I found https://github.com/exiang/php-font-awesome-to-png but haven't tried it. Oddly hard to find "zip file of all font awesome images as png". I did find them as pngs but someone decided all the icons needed new names.