Page MenuHomePhabricator

Allow older, invalid project tags to continue to function
ClosedPublic

Authored by epriestley on Jan 18 2016, 4:57 PM.
Tags
None
Referenced Files
F11399222: D15047.id36339.diff
Tue, Nov 29, 2:49 AM
F11399221: D15047.id36341.diff
Tue, Nov 29, 2:48 AM
F11399220: D15047.id.diff
Tue, Nov 29, 2:48 AM
Unknown Object (File)
Wed, Nov 16, 6:25 AM
Unknown Object (File)
Tue, Nov 15, 10:38 PM
Unknown Object (File)
Thu, Nov 10, 8:08 PM
Unknown Object (File)
Thu, Nov 10, 4:02 AM
Unknown Object (File)
Thu, Nov 10, 4:02 AM
Subscribers
None

Details

Summary

Ref T10168.

Around October 12, T9551 made project hashtags stricter and prevented them from containing characters like comma (,).

Around December 27, D14888 changed how hashtags queries work so that the query does normalization instead of requiring the caller to normalize.

After the Dec 27 change, projects from before Oct 12 with now-invalid hashtags will no longer load when queried directly by hashtag, because the page queries for old,[silly]hash,,tag or whatever, it gets normalized into old_silly_hash_tag, and then there are no hits.

Instead, at least for now, query by both the exact raw text and the normalized hashtag. This should keep older stuff working until we can give users more support for migrating forward.

Test Plan
  • Forced a project to have a bogus hahstag.
  • Before patch: clicking its tag 404'd.
  • After patch: clicking its tag now works.
  • Visited a project by alternate hashtag.
  • Visited a project by denormalized hashtag and alternate hashtag (e.g., capital letters instead of lowercase letters), saw it redirect/normalize properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow older, invalid project tags to continue to function.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 18 2016, 5:00 PM
This revision was automatically updated to reflect the committed changes.