Page MenuHomePhabricator

Improve autocomplete behavior in lists and with noncompleting results
ClosedPublic

Authored by epriestley on Jan 16 2016, 11:04 PM.
Tags
None
Referenced Files
F19089946: D15040.id.diff
Wed, Dec 3, 10:00 AM
F19085296: D15040.diff
Tue, Dec 2, 5:49 PM
F18993252: D15040.diff
Wed, Nov 19, 6:59 AM
F18857785: D15040.diff
Nov 1 2025, 5:52 PM
F18840347: D15040.diff
Oct 27 2025, 11:45 PM
F18840310: D15040.diff
Oct 27 2025, 11:27 PM
F18790464: D15040.id36325.diff
Oct 15 2025, 2:42 PM
F18643575: D15040.id.diff
Sep 19 2025, 2:43 AM
Subscribers
None

Details

Summary

Ref T10163. Currently, we don't activate on indented lines, but were too aggressive about this, and would not activate on lines like - Hey, @user..., where we should.

Instead, don't activate on indented lines if there's only an indent (i.e., # probably means enumerated list).

Also, if results don't have autocompletes (rare but possible with projects missing slugs), improve behavior.

Test Plan
  • Typed #a, got no autocomplete.
  • Missing slug thing is a pain to test locallly, #1 z z z z reproduces in production. I'll just verify it there.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve autocomplete behavior in lists and with noncompleting results.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2016, 11:17 PM
This revision was automatically updated to reflect the committed changes.