Page MenuHomePhabricator

Hide the autocompleter intelligently when you ignore it and keep typing
ClosedPublic

Authored by epriestley on Jan 16 2016, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 1:52 PM
Unknown Object (File)
Sat, Apr 27, 11:59 AM
Unknown Object (File)
Wed, Apr 24, 9:59 PM
Unknown Object (File)
Sun, Apr 21, 3:57 PM
Unknown Object (File)
Sat, Apr 20, 12:18 AM
Unknown Object (File)
Fri, Apr 19, 4:25 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Subscribers
None

Details

Summary

Ref T10163. When we think the user has finished typing a word (because they typed a space, period, or other similar characters) and nothing else they might type could possibly change the outcome (usually because the words they have typed already match nothing), just deactivate the autocomplete.

As a special case, if the word they have typed already select exactly one result, and they have already typed exactly that result, assume they just typed it from memory and deactivate.

Test Plan
  • Typed @dog qwer zxcv and saw autocomplete deactivate on the space before z (on my local install, @dog is ambiguous but @dog qwer matches nothing).
  • Typed @epriestley and saw autocomplete deactivate on space.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide the autocompleter intelligently when you ignore it and keep typing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2016, 10:38 PM
This revision was automatically updated to reflect the committed changes.