Page MenuHomePhabricator

PHUIIconCircleView
ClosedPublic

Authored by chad on Jan 16 2016, 5:39 AM.
Tags
None
Referenced Files
F18085649: D15034.id.diff
Tue, Aug 5, 7:21 PM
F18032866: D15034.id36314.diff
Sun, Aug 3, 12:34 AM
F17998516: D15034.diff
Sat, Aug 2, 5:52 AM
F17815781: D15034.id.diff
Fri, Jul 25, 10:14 PM
F17793554: D15034.diff
Thu, Jul 24, 11:07 PM
F17760029: D15034.diff
Tue, Jul 22, 7:08 PM
F17628706: D15034.id36340.diff
Jul 10 2025, 7:55 AM
Unknown Object (File)
Jun 27 2025, 10:14 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by avivey.

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP2144d877ee30: PHUIIconCircleView
Summary

Icon in a circle. Base class, not much in the way of color choices.

Test Plan

UIExamples, Chrome.

pasted_file (131×342 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to PHUIIconCircleView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 18 2016, 3:08 PM
This revision was automatically updated to reflect the committed changes.

I'm not immediately having much luck getting this integrated cleanly into a menu context, so I'm going to leave it for the moment. If I swap the icon for a circle-icon it creates a lot of rule collisions with the existing menu code that throw off spacing, sizing, highlighting, etc:

Screen Shot 2016-01-19 at 10.40.35 AM.png (144×302 px, 11 KB)

You're welcome to leave the normal icons and I can back. Also, I'd place both links on one line if we're going to do the slightly wider "collapsed" sidenav with names.