Page MenuHomePhabricator

Better fix for autocomplete blur (select on mousedown instead of delaying blur)
ClosedPublic

Authored by epriestley on Jan 15 2016, 5:40 PM.
Tags
None
Referenced Files
F14352966: D15032.diff
Thu, Dec 19, 3:50 PM
Unknown Object (File)
Tue, Dec 17, 1:29 PM
Unknown Object (File)
Mon, Dec 16, 3:49 AM
Unknown Object (File)
Sun, Dec 15, 2:47 PM
Unknown Object (File)
Fri, Dec 13, 4:38 PM
Unknown Object (File)
Sun, Dec 1, 11:00 AM
Unknown Object (File)
Tue, Nov 26, 2:26 AM
Unknown Object (File)
Sun, Nov 24, 1:00 AM
Subscribers
None

Details

Summary

Ref T10163. I would still sometimes not get a replacement after clicking with the delayed blur. This seems to fix the issue more consistently: instead of listening for a click event (which fires after the blur), listen for a mousedown event (which fires before the blur).

Test Plan

Observed consistent selection via mouse locally.

Diff Detail

Repository
rP Phabricator
Branch
auto2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10145
Build 12307: Run Core Tests
Build 12306: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Better fix for autocomplete blur (select on mousedown instead of delaying blur).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 5:47 PM
This revision was automatically updated to reflect the committed changes.