Page MenuHomePhabricator
Differential D15026

Add a motivational profile menu panel
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 11:33 PM.
Tags
None
Referenced Files
F13238102: D15026.id36284.diff
Tue, May 21, 5:06 PM
F13238101: D15026.id36283.diff
Tue, May 21, 5:06 PM
F13235844: D15026.diff
Tue, May 21, 6:52 AM
F13224525: D15026.diff
Sun, May 19, 9:01 AM
F13220817: D15026.diff
Sun, May 19, 1:58 AM
F13217657: D15026.id36307.diff
Sat, May 18, 6:53 AM
F13202177: D15026.diff
Tue, May 14, 10:21 PM
F13190078: D15026.diff
Sat, May 11, 7:37 AM
View All Files
Subscribers
None
Tokens
"Love" token, awarded by quiddity.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP77447fc94583: Add a motivational profile menu panel
Summary

Motivate your employees with inspirational quotes. A new quote every day!

Test Plan

So inspirational.

Diff Detail

Repository
rP Phabricator
Branch
pmenu8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10115
Build 12263: Run Core Tests
Build 12262: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36283.Jan 14 2016, 11:33 PM
epriestley retitled this revision from to Add a motivational profile menu panel.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptJan 14 2016, 11:33 PM
epriestley added a comment.Jan 14 2016, 11:33 PM

Screen Shot 2016-01-14 at 3.31.33 PM.png (1×1 px, 165 KB)

chad accepted this revision.Jan 14 2016, 11:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2016, 11:36 PM
chad added a comment.Jan 14 2016, 11:40 PM

epriestley updated this revision to Diff 36284.Jan 14 2016, 11:47 PM
epriestley edited edge metadata.
  • Improve aesthetics.
chad added a comment.Jan 15 2016, 12:09 AM

not sure how this collapses. In general I thought there would be two menus (narrow and wide) and we'd fly one out over the other...

epriestley added a comment.Jan 15 2016, 12:11 AM

I'll probably just hide it completely on collapse, or maybe just put a paw icon (in a circle??!) with the fact on a tooltip.

epriestley added a comment.Jan 15 2016, 12:17 AM

(I'm hoping to avoid rendering two separate menus because that makes future elements that might have JS a lot messier, but we'll see how much success I have with that.)

chad added a comment.Jan 15 2016, 12:22 AM

time to see what css magic awaits at caniuse.com

epriestley mentioned this in Blog Post: Request for Cat Facts.Jan 15 2016, 2:00 PM
Closed by commit rP77447fc94583: Add a motivational profile menu panel (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:14 PM
This revision was automatically updated to reflect the committed changes.
quiddity awarded a token.Mar 8 2016, 11:29 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
2 lines
applications/
search/
profilepanel/
138 lines
webroot/
rsrc/
css/
phui/
7 lines

Diff 36283

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorMotivatorProfilePanel.php

Loading...
View Options

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...
Phabricator · Built by Phacility