Page MenuHomePhabricator
Differential D15024

Add a visual divider element to profile menus
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 5:56 AM
Unknown Object (File)
Thu, Nov 21, 10:44 AM
Unknown Object (File)
Mon, Nov 18, 4:04 AM
Unknown Object (File)
Sat, Nov 16, 7:30 PM
Unknown Object (File)
Oct 25 2024, 10:14 AM
Unknown Object (File)
Oct 18 2024, 1:05 AM
Unknown Object (File)
Oct 18 2024, 12:49 AM
Unknown Object (File)
Oct 15 2024, 10:59 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10054: Define product direction for Project/Profile UIs
Commits
Restricted Diffusion Commit
rP22aebab1c18c: Add a visual divider element to profile menus
Summary

Ref T10054.

Test Plan

Screen Shot 2016-01-14 at 2.34.10 PM.png (1×1 px, 171 KB)

Diff Detail

Repository
rP Phabricator
Branch
pmenu7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10112
Build 12258: Run Core Tests
Build 12257: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36280.Jan 14 2016, 10:35 PM
epriestley retitled this revision from to Add a visual divider element to profile menus.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10054: Define product direction for Project/Profile UIs.
Herald edited edge metadata. · View Herald TranscriptJan 14 2016, 10:35 PM
chad edited edge metadata.Jan 14 2016, 10:36 PM

r u srs

epriestley added a comment.Jan 14 2016, 10:37 PM

its in the mock!!!!!!!!!!

mock.png (1×2 px, 887 KB)

chad accepted this revision.Jan 14 2016, 10:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2016, 10:39 PM
chad added a comment.Jan 14 2016, 10:40 PM

this configuration is per project, right, (not user per project?)

epriestley added a comment.Jan 14 2016, 10:40 PM

Yeah, per project. I think that'll be right almost all the time, except that we may need some "copy from project" sort of tools later.

chad added a comment.Jan 14 2016, 10:41 PM

http://catfacts-api.appspot.com/doc.html

Closed by commit rP22aebab1c18c: Add a visual divider element to profile menus (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
2 lines
applications/
search/
profilepanel/
48 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 36280

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorDividerProfilePanel.php

Loading...
View Options

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...
Phabricator · Built by Phacility