Page MenuHomePhabricator
Differential D15022

Remove icon nav entirely
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 12:31 PM
Unknown Object (File)
Sat, Mar 1, 8:35 AM
Unknown Object (File)
Tue, Feb 25, 2:13 AM
Unknown Object (File)
Feb 9 2025, 12:28 AM
Unknown Object (File)
Feb 9 2025, 12:28 AM
Unknown Object (File)
Feb 9 2025, 12:28 AM
Unknown Object (File)
Jan 30 2025, 4:38 AM
Unknown Object (File)
Jan 24 2025, 11:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10054: Define product direction for Project/Profile UIs
Commits
Restricted Diffusion Commit
rPf4c8cdb39a14: Remove icon nav entirely
Summary

Ref T10054. People, projects, and instances no longer use icon nav, so we can get rid of it in favor of profile menus.

Test Plan

Grepped for everything, looked through workboards/profiles again.

Diff Detail

Repository
rP Phabricator
Branch
pmenu6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10110
Build 12255: Run Core Tests
Build 12254: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36276.Jan 14 2016, 3:18 PM
epriestley retitled this revision from to Remove icon nav entirely.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10054: Define product direction for Project/Profile UIs.
Herald edited edge metadata. · View Herald TranscriptJan 14 2016, 3:18 PM
chad accepted this revision.Jan 14 2016, 9:30 PM
chad edited edge metadata.

filepicker-UV0iKO6pRLWHVFPIfqTu_olde_english_pouring.jpg (329×347 px, 43 KB)

This revision is now accepted and ready to land.Jan 14 2016, 9:30 PM
epriestley added a comment.Jan 14 2016, 9:32 PM

hehehe

Closed by commit rPf4c8cdb39a14: Remove icon nav entirely (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
view/
layout/
29 lines
phui/
1 line
webroot/
rsrc/
css/
application/
base/
4 lines
layout/
62 lines
phui/
1 line
12 lines

Diff 36276

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

src/view/phui/PHUIListItemView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-side-menu-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workboard-view.css

Loading...
Phabricator · Built by Phacility