Differential D15016

Rough initial cut of profile new profile menu
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 1:04 AM.

Details

Reviewers

chad

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP468031d1fd77: Rough initial cut of profile new profile menu

Summary

Ref T10054. I haven't done any of the big-picture layout stuff yet, but this should get look-and-feel somewhere in the ballpark of reasonablness, I think.

Major missing stuff:

No "collapse" state or action yet.
Menu is not full-height (requires changes to the rendering pipeline).

Test Plan

Screen Shot 2016-01-13 at 4.59.39 PM.png (1×1 px, 206 KB)

Diff Detail

Repository

rP Phabricator

Branch

pmenu2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10102
Build 12243: Run Core Tests
Build 12242: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36268.Jan 14 2016, 1:04 AM

epriestley retitled this revision from to Rough initial cut of profile new profile menu.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

Herald edited edge metadata. · View Herald TranscriptJan 14 2016, 1:04 AM

I'll hold this until full-height is also built/approved since the partial-height is super weird. I probably got colors/layouts not-quite-right, feel free to counterdiff on anything that looks a bit off.

chad accepted this revision.Jan 14 2016, 9:06 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2016, 9:06 PM

Closed by commit rP468031d1fd77: Rough initial cut of profile new profile menu (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.