Fix a bad lookup in hovercards
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 7:52 PM.

Tags

None

Referenced Files

	F14058358: D14987.diff
	Sun, Nov 17, 11:14 AM

	F14037086: D14987.id36207.diff
	Sun, Nov 10, 1:45 PM

	F14036986: D14987.id36206.diff
	Sun, Nov 10, 1:17 PM

	F13977692: D14987.diff
	Oct 18 2024, 7:37 PM

	F13972198: D14987.id36207.diff
	Oct 17 2024, 5:39 PM

	F13968151: D14987.id.diff
	Oct 16 2024, 6:56 PM

	Unknown Object (File)
	Sep 20 2024, 12:40 PM

	Unknown Object (File)
	Sep 10 2024, 4:17 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPe84693f589d3: Fix a bad lookup in hovercards

Summary

If you try to pull the hovercard of something you can no longer see (maybe you loaded the page, then the policy changed) there won't be a value in the array here.

(The rest of the code anticipates this possibility.)

Test Plan

Hovered some stuff.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36206.Jan 10 2016, 7:52 PM

epriestley retitled this revision from to Fix a bad lookup in hovercards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Jan 10 2016, 7:59 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 10 2016, 7:59 PM

Closed by commit rPe84693f589d3: Fix a bad lookup in hovercards (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

2 lines

Diff 36207

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Fix a bad lookup in hovercardsClosedPublicActions