Page MenuHomePhabricator
Differential D14968

Move commit attachment to a separate CLI command
ClosedPublic
Actions

Authored by epriestley on Jan 8 2016, 1:39 PM.
Tags
None
Referenced Files
F19030254: D14968.diff
Mon, Nov 24, 8:33 PM
F19018688: D14968.diff
Nov 23 2025, 12:13 PM
F18945791: D14968.id36171.diff
Nov 11 2025, 6:55 PM
F18804262: D14968.id36171.diff
Oct 18 2025, 7:05 AM
F18796560: D14968.id36171.diff
Oct 17 2025, 3:46 AM
F18790835: D14968.id36162.diff
Oct 15 2025, 7:36 PM
F18784686: D14968.id36171.diff
Oct 13 2025, 2:33 PM
F18760895: D14968.id36162.diff
Oct 6 2025, 11:11 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9319: Accessing image file in Diffusion must not generate error (unhandled exception)
Commits
Restricted Diffusion Commit
rP413ca12fda6b: Move commit attachment to a separate CLI command
Summary

Ref T9319. See D14967. As before, this is making a deeply-buried, complex operation easier to test by providing a CLI command.

This adds bin/differential attach-commit rXnnnn Dnnnn to pretend that rXnnnn was just committed and matched Dnnnn.

Test Plan
  • Ran bin/differential attach-commit X Y for several different values, saw updates in the UI.
  • Faked the message parser to make sure stuff still worked there.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36162.Jan 8 2016, 1:39 PM
epriestley retitled this revision from to Move commit attachment to a separate CLI command.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9319: Accessing image file in Diffusion must not generate error (unhandled exception).
chad accepted this revision.Jan 8 2016, 3:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 3:53 PM
Closed by commit rP413ca12fda6b: Move commit attachment to a separate CLI command (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
engine/
170 lines
management/
90 lines
repository/
worker/
commitmessageparser/
156 lines

Diff 36171

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/engine/DifferentialDiffExtractionEngine.php

Loading...
View Options

src/applications/differential/management/PhabricatorDifferentialAttachCommitWorkflow.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility