Page MenuHomePhabricator

Move diff extraction from commits to a separate test with a CLI command
ClosedPublic

Authored by epriestley on Jan 8 2016, 12:42 PM.
Tags
None
Referenced Files
F13083590: D14967.diff
Wed, Apr 24, 10:39 PM
Unknown Object (File)
Fri, Apr 19, 4:04 PM
Unknown Object (File)
Wed, Apr 17, 3:16 PM
Unknown Object (File)
Thu, Apr 11, 12:16 PM
Unknown Object (File)
Thu, Apr 11, 7:36 AM
Unknown Object (File)
Mar 21 2024, 3:58 AM
Unknown Object (File)
Feb 16 2024, 2:10 PM
Unknown Object (File)
Feb 11 2024, 12:12 PM
Subscribers
None

Details

Summary

Ref T9319. When we discover a commit, we sometimes update the corresponding revision with a "this is the actual committed change" diff and send out a link to the changes between review and commit.

This is currently very difficult to test, because it only happens the first time and you have to either go set up a bunch of objects or add a bunch of special casing to the parser to hit the workflow.

I'm making some changes to how it pulls file content. To make those changes easier to test, first start extracting this stuff so the code can be run with bin/differential extract ... instead of needing to do a bunch of more complicated setup steps.

Test Plan
  • Ran bin/differential extract ... to extract diffs from commits.
  • Forced my way through the daemon workflow by faking out a bunch of flags, got a clean extract + attach + update. After this patch, this should rarely be necessary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move diff extraction from commits to a separate test with a CLI command.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.