Page MenuHomePhabricator

Move diff extraction from commits to a separate test with a CLI command
ClosedPublic

Authored by epriestley on Jan 8 2016, 12:42 PM.
Tags
None
Referenced Files
F15494553: D14967.id36161.diff
Sun, Apr 13, 12:40 AM
F15485863: D14967.id36168.diff
Thu, Apr 10, 3:04 AM
F15458908: D14967.id36168.diff
Mon, Mar 31, 8:10 AM
F15452564: D14967.id.diff
Sat, Mar 29, 6:00 AM
F15443089: D14967.id.diff
Thu, Mar 27, 2:17 AM
F15421468: D14967.id36161.diff
Sat, Mar 22, 12:02 AM
F15415120: D14967.diff
Thu, Mar 20, 4:10 AM
F15384926: D14967.id.diff
Fri, Mar 14, 9:12 PM
Subscribers
None

Details

Summary

Ref T9319. When we discover a commit, we sometimes update the corresponding revision with a "this is the actual committed change" diff and send out a link to the changes between review and commit.

This is currently very difficult to test, because it only happens the first time and you have to either go set up a bunch of objects or add a bunch of special casing to the parser to hit the workflow.

I'm making some changes to how it pulls file content. To make those changes easier to test, first start extracting this stuff so the code can be run with bin/differential extract ... instead of needing to do a bunch of more complicated setup steps.

Test Plan
  • Ran bin/differential extract ... to extract diffs from commits.
  • Forced my way through the daemon workflow by faking out a bunch of flags, got a clean extract + attach + update. After this patch, this should rarely be necessary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move diff extraction from commits to a separate test with a CLI command.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.