Page MenuHomePhabricator
Differential D14965

Fix two minor issues with blame that involves revisions
ClosedPublic
Actions

Authored by epriestley on Jan 7 2016, 2:53 AM.
Tags
None
Referenced Files
F14835005: D14965.id36159.diff
Thu, Jan 30, 6:27 PM
Unknown Object (File)
Mon, Jan 27, 7:55 AM
Unknown Object (File)
Fri, Jan 24, 11:00 AM
Unknown Object (File)
Fri, Jan 24, 11:00 AM
Unknown Object (File)
Fri, Jan 24, 10:59 AM
Unknown Object (File)
Fri, Jan 24, 10:59 AM
Unknown Object (File)
Wed, Jan 22, 2:36 PM
Unknown Object (File)
Mon, Jan 20, 10:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPd725dedb1eda: Fix two minor issues with blame that involves revisions
Summary

I was looking at some random un-revisioney repository for most of my testing and missed these.

Test Plan

Viewed blame of a file with some revisions.

Diff Detail

Repository
rP Phabricator
Branch
blamerev
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9983
Build 12064: Run Core Tests
Build 12063: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36158.Jan 7 2016, 2:53 AM
epriestley retitled this revision from to Fix two minor issues with blame that involves revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 7 2016, 2:55 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2016, 2:55 AM
Closed by commit rPd725dedb1eda: Fix two minor issues with blame that involves revisions (authored by epriestley, committed by epriestley). · Explain WhyJan 7 2016, 2:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
4 lines

Diff 36158

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility