Page MenuHomePhabricator

Merge and modernize Browse controllers in Diffusion
ClosedPublic

Authored by epriestley on Jan 5 2016, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 1:07 PM
Unknown Object (File)
Tue, Mar 5, 5:22 PM
Unknown Object (File)
Feb 19 2024, 5:46 AM
Unknown Object (File)
Feb 13 2024, 1:13 PM
Unknown Object (File)
Feb 8 2024, 1:20 AM
Unknown Object (File)
Feb 8 2024, 1:20 AM
Unknown Object (File)
Feb 8 2024, 1:20 AM
Unknown Object (File)
Feb 7 2024, 3:17 PM
Subscribers
None

Details

Summary

Ref T4245. Browsing is huge and currently split across 5 files using controller delegation.

Although having a huge file isn't great, I think the way it is split up is currently worse, and it gets weird with more flexible repository identifiers.

So this is mostly merging five controllers into one, then a bit of modernization.

I think this can probably be split up better by pulling some of it out into views, instead of using delegation.

Test Plan

Browsed files, directories, and search results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Merge and modernize Browse controllers in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.